Skip to content

[release-1.19] Fix min-scale transition #16101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 18, 2025
Merged

[release-1.19] Fix min-scale transition #16101

merged 7 commits into from
Oct 18, 2025

Conversation

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Sep 29, 2025

This is an automated cherry-pick of #16094

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 29, 2025
Merged
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 29, 2025
@knative-prow knative-prow bot requested review from dprotaso and skonto September 29, 2025 17:10
@dprotaso
Copy link
Member

dprotaso commented Sep 29, 2025

/lgtm
/approve

I might see if there are other patches we might want to merge along with this one

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.08%. Comparing base (634af56) to head (3c0c22d).
⚠️ Report is 1 commits behind head on release-1.19.

Files with missing lines Patch % Lines
pkg/testing/v1/configuration.go 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.19   #16101      +/-   ##
================================================
- Coverage         80.24%   80.08%   -0.16%     
================================================
  Files               214      214              
  Lines             16893    16909      +16     
================================================
- Hits              13555    13541      -14     
- Misses             2978     3004      +26     
- Partials            360      364       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member

dprotaso commented Oct 18, 2025

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2025
@knative-prow knative-prow bot merged commit d11fb31 into knative:release-1.19 Oct 18, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@skonto skonto Awaiting requested review from skonto

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knative-prow-robot @dprotaso